[18.0][MIG] mrp_progress_button: Migration to 18.0#1729
[18.0][MIG] mrp_progress_button: Migration to 18.0#1729
Conversation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-12.0/manufacture-12.0-mrp_progress_button Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-mrp_progress_button/
Currently translated at 100.0% (2 of 2 strings) Translation: manufacture-12.0/manufacture-12.0-mrp_progress_button Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-mrp_progress_button/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-14.0/manufacture-14.0-mrp_progress_button Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_progress_button/
Currently translated at 100.0% (3 of 3 strings) Translation: manufacture-15.0/manufacture-15.0-mrp_progress_button Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_progress_button/it/
Currently translated at 100.0% (3 of 3 strings) Translation: manufacture-15.0/manufacture-15.0-mrp_progress_button Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_progress_button/it/
Currently translated at 100.0% (6 of 6 strings) Translation: manufacture-15.0/manufacture-15.0-mrp_progress_button Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_progress_button/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-15.0/manufacture-15.0-mrp_progress_button Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_progress_button/
Killance
force-pushed
the
18.0-mig-mrp_progress_button
branch
2 times, most recently
from
c769522 to
c9c1658
Compare
Killance
force-pushed
the
18.0-mig-mrp_progress_button
branch
from
c9c1658 to
2bd8f19
Compare
Killance
force-pushed
the
18.0-mig-mrp_progress_button
branch
from
2bd8f19 to
ff604ac
Compare
Killance
force-pushed
the
18.0-mig-mrp_progress_button
branch
from
ff604ac to
12728c9
Compare
Tisho99
left a comment
Tisho99
left a comment
There was a problem hiding this comment.
Hello @Killance
I have been reviewing this and found a few lines of code that could be improved.
The migration is also missing the "[IMP] $module: pre-commit auto fixes" commit.
Most of the guidelines are explained here: https://github.com/OCA/maintainer-tools/wiki#migration
As this PR has been inactive for 2 months, I will try to finish it in another PR unless you let me know that you would prefer to continue working on it.
Thank you for the migration.
|
|
||
|
|
||
| class TestProgressButton(TransactionCase): | ||
| def setUp(self, *args, **kwargs): |
There was a problem hiding this comment.
I think this should be changed by setupClass
| "author": "Akretion, Odoo Community Association (OCA)", | ||
| "website": "https://github.com/OCA/manufacture", | ||
| "category": "Manufacturing", | ||
| "version": "18.0.2.0.0", |
There was a problem hiding this comment.
Version should be "18.0.1.0.0"
| { | ||
| "name": "Manuf", | ||
| "type": "product", | ||
| "type": "consu", |
There was a problem hiding this comment.
I think that the is_storable should also be added, shouldn't it?
| ) | ||
| def _compute_state(self): | ||
| res = super()._compute_state() | ||
| super()._compute_state() |
There was a problem hiding this comment.
I think this return should not be removed because you should return what you get from super()
| production.state = "progress" | ||
| return res | ||
| elif ( | ||
| ctx.get("previous_state") == "progress" |
There was a problem hiding this comment.
I haven't found this context key in standard Odoo.
I think that the reason to add this logic should be expliained, as it seems very custom
15 participants
No description provided.